linux-kernel - Re: [PATCH 1/2] perf tools: Compare dso's also when comparing symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131015060829.GA4529@gmail.com>
Date:	Tue, 15 Oct 2013 08:08:29 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 1/2] perf tools: Compare dso's also when comparing symbols


* Namhyung Kim <namhyung@...nel.org> wrote:

> From: Namhyung Kim <namhyung.kim@....com>
> 
> Linus reported that sometimes 'perf report -s symbol' exits without any 
> message on TUI.  David and Jiri found that it's because it failed to add 
> a hist entry due to an invalid symbol length.

Btw., 'exit without any messages' is something that should be fixed 
separately as well I suspect.

>  static int64_t
>  sort__sym_cmp(struct hist_entry *left, struct hist_entry *right)
>  {
> +	int64_t ret;
> +

Btw., this file should go back to u64/s64 like the kernel and most of perf 
does. (A few int64_t uses slipped into other places as well, I suspect 
they should be fixed.)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/