linux-kernel - Re: [PATCH 1/3 v3] exynos: i2c: Fix i2c driver to handle NACKs properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <525CDB51.70408@denx.de>
Date:	Tue, 15 Oct 2013 08:06:09 +0200
From:	Heiko Schocher <hs@...x.de>
To:	Naveen Krishna Chatradhi <ch.naveen@...sung.com>
CC:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, khali@...ux-fr.org,
	ben-linux@...ff.org, grant.likely@...retlab.ca, sjg@...omium.org,
	naveenkrishna.ch@...il.com, d.mueller@...oft.ch, trini@...com,
	mk7.kang@...sung.com, cpgs@...sung.com
Subject: Re: [PATCH 1/3 v3] exynos: i2c: Fix i2c driver to handle NACKs properly

Hello Naveen,

Am 15.10.2013 07:12, schrieb Naveen Krishna Chatradhi:
> The Exynos5 i2c driver does not handle NACKs properly. This change:
>
> - fixes the NACK processing problem (do not continue transaction if
>    address cycle was NACKed)
>
> - eliminates a fair amount of duplicate code
>
> Signed-off-by: Vadim Bendebury<vbendeb@...omium.org>
> Reviewed-by: Simon Glass<sjg@...gle.com>
> Signed-off-by: Naveen Krishna Chatradhi<ch.naveen@...sung.com>
> ---
> Changes since v1:
> Fixed complilation warning in function i2c_init()
>
> Changes since v2:
> None
>
>   drivers/i2c/s3c24x0_i2c.c |  214 +++++++++++++++++++--------------------------
>   1 file changed, 90 insertions(+), 124 deletions(-)

Hmm.. I think your patchset is for u-boot, or? But I could not find
the u-boot ml on cc... instead some linux ml ... if so, please resend
to the u-boot ml ...

(matches for all three patches from you)

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/