linux-kernel - Re: [PATCH] s390: Remove unused variable in copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131015091718.003f3fb7@mschwide>
Date:	Tue, 15 Oct 2013 09:17:18 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Michael Holzheu <holzheu@...ux.vnet.ibm.com>,
	linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390: Remove unused variable in copy_from_realmem()

On Tue, 15 Oct 2013 08:50:11 +0200
Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

> arch/s390/kernel/crash_dump.c: In function 'copy_from_realmem':
> arch/s390/kernel/crash_dump.c:48:6: warning: unused variable 'rc' [-Wunused-variable]
> 
> Introduced by commit 4d3b0664a0d0c0dc7501cfbd067f74226aeca510 ("s390: Allow
> vmalloc target buffers for copy_from_oldmem()").
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  arch/s390/kernel/crash_dump.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/s390/kernel/crash_dump.c b/arch/s390/kernel/crash_dump.c
> index 7dd21720e5b0..3db6af0601a5 100644
> --- a/arch/s390/kernel/crash_dump.c
> +++ b/arch/s390/kernel/crash_dump.c
> @@ -45,7 +45,6 @@ static inline void *load_real_addr(void *addr)
>  static int copy_from_realmem(void *dest, void *src, size_t count)
>  {
>  	unsigned long size;
> -	int rc;
> 
>  	if (!count)
>  		return 0;

Thanks for the hint but there is already a equivalent patch from Heiko on the
features branch on git-s390. I plan to get it pulled in the merge window for
3.13 as I feel that the warning is not important enough to fix it now.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/