linux-kernel - Re: [tip:sched/core] sched/numa: Introduce migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131015095527.GH11028@suse.de>
Date:	Tue, 15 Oct 2013 10:55:27 +0100
From:	Mel Gorman <mgorman@...e.de>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	mingo@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	hannes@...xchg.org, riel@...hat.com, aarcange@...hat.com,
	srikar@...ux.vnet.ibm.com, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/core] sched/numa: Introduce migrate_swap()

On Thu, Oct 10, 2013 at 08:17:22PM +0200, Peter Zijlstra wrote:
> On Wed, Oct 09, 2013 at 10:30:13AM -0700, tip-bot for Peter Zijlstra wrote:
> > sched/numa: Introduce migrate_swap()
> 
> Thanks to Rik for writing the Changelog!
> 
> ---
> From: Peter Zijlstra <peterz@...radead.org>
> Subject: sched: Fix race in migrate_swap_stop
> 
> There is a subtle race in migrate_swap, when task P, on CPU A, decides to swap
> places with task T, on CPU B.
> 
> Task P:
>   - call migrate_swap
> Task T:
>   - go to sleep, removing itself from the runqueue
> Task P:
>   - double lock the runqueues on CPU A & B
> Task T:
>   - get woken up, place itself on the runqueue of CPU C
> Task P:
>   - see that task T is on a runqueue, and pretend to remove it
>     from the runqueue on CPU B
> 
> Now CPUs B & C both have corrupted scheduler data structures.
> 
> This patch fixes it, by holding the pi_lock for both of the tasks
> involved in the migrate swap. This prevents task T from waking up,
> and placing itself onto another runqueue, until after migrate_swap
> has released all locks.
> 
> This means that, when migrate_swap checks, task T will be either
> on the runqueue where it was originally seen, or not on any
> runqueue at all. Migrate_swap deals correctly with of those cases.
> 
> Signed-off-by: Peter Zijlstra <peterz@...radead.org>
> Tested-by: Joe Mario <jmario@...hat.com>

Acked-by: Mel Gorman <mgorman@...e.de>

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/