linux-kernel - RE: [PATCH 07/12] mm, thp, tmpfs: handle huge page in shmem_undo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131015110146.7E8BEE0090@blue.fi.intel.com>
Date:	Tue, 15 Oct 2013 14:01:46 +0300 (EEST)
From:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To:	Ning Qu <quning@...gle.com>
Cc:	Andrea Arcangeli <aarcange@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Hugh Dickins <hughd@...gle.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Hugh Dickins <hughd@...gle.com>,
	Wu Fengguang <fengguang.wu@...el.com>, Jan Kara <jack@...e.cz>,
	Mel Gorman <mgorman@...e.de>, linux-mm@...ck.org,
	Andi Kleen <ak@...ux.intel.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Hillf Danton <dhillf@...il.com>, Dave Hansen <dave@...1.net>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ning Qu <quning@...gle.com>
Subject: RE: [PATCH 07/12] mm, thp, tmpfs: handle huge page in
 shmem_undo_range for truncate

Ning Qu wrote:
> When comes to truncate file, add support to handle huge page in the
> truncate range.
> 
> Signed-off-by: Ning Qu <quning@...il.com>
> ---
>  mm/shmem.c | 97 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 86 insertions(+), 11 deletions(-)
> 
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 0a423a9..90f2e0e 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -559,6 +559,7 @@ static void shmem_undo_range(struct inode *inode, loff_t lstart, loff_t lend,
>  	struct shmem_inode_info *info = SHMEM_I(inode);
>  	pgoff_t start = (lstart + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
>  	pgoff_t end = (lend + 1) >> PAGE_CACHE_SHIFT;
> +	/* Whether we have to do partial truncate */
>  	unsigned int partial_start = lstart & (PAGE_CACHE_SIZE - 1);
>  	unsigned int partial_end = (lend + 1) & (PAGE_CACHE_SIZE - 1);
>  	struct pagevec pvec;
> @@ -570,12 +571,16 @@ static void shmem_undo_range(struct inode *inode, loff_t lstart, loff_t lend,
>  	if (lend == -1)
>  		end = -1;	/* unsigned, so actually very big */
>  
> +	i_split_down_read(inode);
>  	pagevec_init(&pvec, 0);
>  	index = start;
>  	while (index < end) {
> +		bool thp = false;
> +
>  		pvec.nr = shmem_find_get_pages_and_swap(mapping, index,
>  				min(end - index, (pgoff_t)PAGEVEC_SIZE),
>  							pvec.pages, indices);
> +
>  		if (!pvec.nr)
>  			break;
>  		mem_cgroup_uncharge_start();
> @@ -586,6 +591,25 @@ static void shmem_undo_range(struct inode *inode, loff_t lstart, loff_t lend,
>  			if (index >= end)
>  				break;
>  
> +			thp = PageTransHugeCache(page);
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE_PAGECACHE

Again. Here and below ifdef is redundant: PageTransHugeCache() is zero
compile-time and  thp case will be optimize out.

And do we really need a copy of truncate logic here? Is there a way to
share code?

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/