linux-kernel - RE: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1310151040330.1377-100000@iolanthe.rowland.org>
Date:	Tue, 15 Oct 2013 10:46:37 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Hartley Sweeten <HartleyS@...ionengravers.com>
cc:	Ryan Mallon <rmallon@...il.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	ARM Kernel <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: RE: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

On Mon, 14 Oct 2013, Hartley Sweeten wrote:

> >>  config USB_OHCI_HCD_PLATFORM
> >>  	tristate "Generic OHCI driver for a platform device"
> >> -	default n
> >> +	default y if ARCH_EP93XX
> >
> > Shouldn't we select USB_OHCI_HCD_PLATFORM, e.g. something like:
> >
> > 	config ARCH_EP93XX_USB
> >		tristate "USB OHCI support"
> >		default y
> >		select USB_OHCI_HCD_PLATFORM
> >
> > In arch/arm/mach-ep93xx/Kconfig rather than polluting
> > drivers/usb/host/Kconfig with arch specific stuff?
> 
> I wasn't sure where the best place to enable 
> USB_OHCI_HCD_PLATFORM would be.
> 
> Currently USB support on the EP93xx only needs USB_OHCI_HCD
> enabled, which is already enabled in the ep93xx_defconfig. I'm not
> sure if adding the config option above would create a problem where
> the user would need to enable USB_OHCI_HCD in drivers/usb then 
> have to go back to the arch stuff to enable ARCH_EP93XX_USB.
> 
> With the default y above they just have to enable USB_OHCI_HCD
> like they currently do.
> 
> I'm hoping Alan can provide some feedback.

In the past this sort of thing has been done in two different ways, 
depending on whether or not OHCI support was previously configurable.

In cases where it was, we kept the old Kconfig entry and made it select
USB_OHCI_HCD_PLATFORM, but added a notice that the entry was now
deprecated.  For example, in drivers/usb/host/Kconfig see the entry for
USB_OHCI_ATH79.

In cases where support was always present (i.e., not configurable), we
added an entry for USB_OHCI_HCD_PLATFORM to the platform's defconfig
file.  For example, see arch/arm/configs/marzen_defconfig.  This is
probably what you want to do.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/