| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Oct 2013 11:15:06 +0800 From: Jason Wang <jasowang@...hat.com> To: "Michael S. Tsirkin" <mst@...hat.com> CC: virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, rusty@...tcorp.com.au Subject: Re: [PATCH net 2/2] virtio-net: refill only when device is up during setting queues On 10/14/2013 07:09 PM, Michael S. Tsirkin wrote: > On Mon, Oct 14, 2013 at 05:56:35PM +0800, Jason Wang wrote: >> > We used to schedule the refill work unconditionally after changing the >> > number of queues. This may lead an issue if the device is not >> > up. Since we only try to cancel the work in ndo_stop(), this may cause >> > the refill work still work after removing the device. Fix this by only >> > schedule the work when device is up. >> > >> > The bug were introduce by commit 9b9cd8024a2882e896c65222aa421d461354e3f2. >> > (virtio-net: fix the race between channels setting and refill) >> > >> > Cc: Rusty Russell <rusty@...tcorp.com.au> >> > Cc: Michael S. Tsirkin <mst@...hat.com> >> > Signed-off-by: Jason Wang <jasowang@...hat.com> > It bothers me that we look at the flag without any > locks here. > I think we'll need to take the rtnl lock at least > on restore. > True, will post v2. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists