linux-kernel - Re: [PATCH 11/12] mm, thp, tmpfs: enable thp page cache in tmpfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACz4_2cVZBxg88hqzOHpASN4e=hVYMTTQkXHssDjfXpcqACONw@mail.gmail.com>
Date:	Tue, 15 Oct 2013 11:42:39 -0700
From:	Ning Qu <quning@...gle.com>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:	Andrea Arcangeli <aarcange@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Wu Fengguang <fengguang.wu@...el.com>, Jan Kara <jack@...e.cz>,
	Mel Gorman <mgorman@...e.de>, linux-mm@...ck.org,
	Andi Kleen <ak@...ux.intel.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Hillf Danton <dhillf@...il.com>, Dave Hansen <dave@...1.net>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/12] mm, thp, tmpfs: enable thp page cache in tmpfs

I agree with this. It has been like this just for a quick proof, but I
need to address this problem as soon as possible.

Thanks!
Best wishes,
-- 
Ning Qu (曲宁) | Software Engineer | quning@...gle.com | +1-408-418-6066


On Tue, Oct 15, 2013 at 4:09 AM, Kirill A. Shutemov
<kirill.shutemov@...ux.intel.com> wrote:
> Ning Qu wrote:
>> Signed-off-by: Ning Qu <quning@...il.com>
>> ---
>>  mm/Kconfig | 4 ++--
>>  mm/shmem.c | 5 +++++
>>  2 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/Kconfig b/mm/Kconfig
>> index 562f12f..4d2f90f 100644
>> --- a/mm/Kconfig
>> +++ b/mm/Kconfig
>> @@ -428,8 +428,8 @@ config TRANSPARENT_HUGEPAGE_PAGECACHE
>>       help
>>         Enabling the option adds support hugepages for file-backed
>>         mappings. It requires transparent hugepage support from
>> -       filesystem side. For now, the only filesystem which supports
>> -       hugepages is ramfs.
>> +       filesystem side. For now, the filesystems which support
>> +       hugepages are: ramfs and tmpfs.
>>
>>  config CROSS_MEMORY_ATTACH
>>       bool "Cross Memory Support"
>> diff --git a/mm/shmem.c b/mm/shmem.c
>> index 75c0ac6..50a3335 100644
>> --- a/mm/shmem.c
>> +++ b/mm/shmem.c
>> @@ -1672,6 +1672,11 @@ static struct inode *shmem_get_inode(struct super_block *sb, const struct inode
>>                       break;
>>               case S_IFREG:
>>                       inode->i_mapping->a_ops = &shmem_aops;
>> +                     /*
>> +                      * TODO: make tmpfs pages movable
>> +                      */
>> +                     mapping_set_gfp_mask(inode->i_mapping,
>> +                                          GFP_TRANSHUGE & ~__GFP_MOVABLE);
>
> Unlike ramfs, tmpfs pages are movable before transparent page cache
> patchset.
> Making tmpfs pages non-movable looks like a big regression to me. It need
> to be fixed before proposing it upstream.
>
> --
>  Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/