lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Oct 2013 23:42:44 +0100 From: Grant Likely <grant.likely@...aro.org> To: Rob Herring <robherring2@...il.com>, Thierry Reding <thierry.reding@...il.com> Cc: Rob Herring <rob.herring@...xeda.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Thomas Gleixner <tglx@...utronix.de>, linux-mips@...ux-mips.org, Russell King <linux@....linux.org.uk>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Ralf Baechle <ralf@...ux-mips.org>, sparclinux@...r.kernel.org, linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v2 01/10] of/irq: Rework of_irq_count() On Sun, 22 Sep 2013 16:19:27 -0500, Rob Herring <robherring2@...il.com> wrote: > On Wed, Sep 18, 2013 at 8:24 AM, Thierry Reding > <thierry.reding@...il.com> wrote: > > The of_irq_to_resource() helper that is used to implement of_irq_count() > > tries to resolve interrupts and in fact creates a mapping for resolved > > interrupts. That's pretty heavy lifting for something that claims to > > just return the number of interrupts requested by a given device node. > > > > Instead, use the more lightweight of_irq_map_one(), which, despite the > > name, doesn't create an actual mapping. Perhaps a better name would be > > of_irq_translate_one(). > > > > Signed-off-by: Thierry Reding <treding@...dia.com> > > Acked-by: Rob Herring <rob.herring@...xeda.com> Applied (and fixed to match the of_irq_map_one --> of_irq_parse_one rename that I'm going to merge in v3.13). g. > > > --- > > drivers/of/irq.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/of/irq.c b/drivers/of/irq.c > > index 1752988..5f44388 100644 > > --- a/drivers/of/irq.c > > +++ b/drivers/of/irq.c > > @@ -368,9 +368,10 @@ EXPORT_SYMBOL_GPL(of_irq_to_resource); > > */ > > int of_irq_count(struct device_node *dev) > > { > > + struct of_irq irq; > > int nr = 0; > > > > - while (of_irq_to_resource(dev, nr, NULL)) > > + while (of_irq_map_one(dev, nr, &irq) == 0) > > nr++; > > > > return nr; > > -- > > 1.8.4 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@...ts.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists