linux-kernel - Re: [PATCH] x86, relocs: add percpu fixup for GNU ld 2.23

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <525E3786.7030102@zytor.com>
Date:	Tue, 15 Oct 2013 23:51:50 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Kees Cook <keescook@...omium.org>, Ingo Molnar <mingo@...nel.org>
CC:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	x86@...nel.org, Michael Davidson <md@...gle.com>,
	Cong Ding <dinggnu@...il.com>
Subject: Re: [PATCH] x86, relocs: add percpu fixup for GNU ld 2.23

On 10/15/2013 11:43 PM, Kees Cook wrote:
> The GNU linker tries to put __per_cpu_load into the percpu area, resulting
> in a lack of its relocation. Force this symbol to be relocated. Seen
> starting with GNU ld 2.23 and later.
> 
> Reported-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  arch/x86/tools/relocs.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c
> index 1fa291f..7a85f29 100644
> --- a/arch/x86/tools/relocs.c
> +++ b/arch/x86/tools/relocs.c
> @@ -729,6 +729,7 @@ static void percpu_init(void)
>   *
>   * The GNU linker incorrectly associates:
>   *	__init_begin
> + *	__per_cpu_load
>   *
>   * The "gold" linker incorrectly associates:
>   *	init_per_cpu__irq_stack_union
> @@ -738,6 +739,7 @@ static int is_percpu_sym(ElfW(Sym) *sym, const char *symname)
>  {
>  	return (sym->st_shndx == per_cpu_shndx) &&
>  		strcmp(symname, "__init_begin") &&
> +		strcmp(symname, "__per_cpu_load") &&
>  		strncmp(symname, "init_per_cpu_", 13);
>  }
>  
> 

Why isn't this list using a regex like other symbol classes?

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/