linux-kernel - Re: [PATCH 1/1] cx23885-dvb: fix ds3000 ts2020 split for TEVII S471

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131016070245.GA3296@Loki.fritz.box>
Date:	Wed, 16 Oct 2013 09:16:08 +0200
From:	Johannes Koch <johannes@...sraum.de>
To:	Mauro Carvalho Chehab <m.chehab@...sung.com>
Cc:	linux-kernel@...r.kernel.org, Christian Volkmann <cv@...sv.de>
Subject: Re: [PATCH 1/1] cx23885-dvb: fix ds3000 ts2020 split for TEVII S471

Hi  Mauro,

On Thu, Sep 26, 2013 at 01:51:57PM -0300, Mauro Carvalho Chehab wrote:
> The difference between your patch and the applied one is:
> 
> diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers/media/pci/cx23885/cx23885-dvb.c
> index 971e4ff..8ed7b94 100644
> --- a/drivers/media/pci/cx23885/cx23885-dvb.c
> +++ b/drivers/media/pci/cx23885/cx23885-dvb.c
> @@ -1055,7 +1055,6 @@ static int dvb_register(struct cx23885_tsport *port)
>  				&tevii_ts2020_config, &i2c_bus->i2c_adap);
>  			fe0->dvb.frontend->ops.set_voltage = f300_set_voltage;
>  		}
> -
>  		break;
>  	case CX23885_BOARD_DVBWORLD_2005:
>  		i2c_bus = &dev->i2c_bus[1];
> @@ -1285,6 +1284,7 @@ static int dvb_register(struct cx23885_tsport *port)
>  		if (fe0->dvb.frontend != NULL) {
>  			dvb_attach(ts2020_attach, fe0->dvb.frontend,
>  				&tevii_ts2020_config, &i2c_bus->i2c_adap);
> +			fe0->dvb.frontend->ops.set_voltage = f300_set_voltage;
>  		}
>  		break;
>  	case CX23885_BOARD_PROF_8000:
> 
> 
> So, basically, on our patch, you're also filling ops.set_voltage. 
> 
> As I don't know the board details, I can't tell if this is required or
> not.
> 
> Christian/Johannes,
> 
> Could you please double-check it? If this is needed, please send me a new
> patch, rebased on the top of linux-media git tree.

no, setting the voltage via dvb.frontend->ops.set_voltage is not needed for
the TeVii S471. See also the patch that introduced S471 support:
https://linuxtv.org/patch/11189/.

Best regards
 Johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/