linux-kernel - Re: [PATCH] x86 efi: efi reverve boot service fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <525E4076.2070107@zytor.com>
Date:	Wed, 16 Oct 2013 00:29:58 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Dave Young <dyoung@...hat.com>, matt@...sole-pimps.org,
	x86@...nel.org, linux-kernel@...r.kernel.org, mjg59@...f.ucam.org,
	James.Bottomley@...senPartnership.com, vgoyal@...hat.com,
	linux-efi@...r.kernel.org
Subject: Re: [PATCH] x86 efi: efi reverve boot service fix

On 10/16/2013 12:11 AM, Dave Young wrote:
>>
>> --- linux-2.6.orig/arch/x86/platform/efi/efi.c
>> +++ linux-2.6/arch/x86/platform/efi/efi.c
>> @@ -440,7 +440,7 @@ void __init efi_reserve_boot_services(vo
>>  		 * - Not within any part of the kernel
>>  		 * - Not the bios reserved area
>>  		*/
>> -		if ((start+size >= __pa_symbol(_text)
>> +		if ((start + size - 1 >= __pa_symbol(_text)
>>  				&& start <= __pa_symbol(_end)) ||
>>  			!e820_all_mapped(start, start+size, E820_RAM) ||
>>  			memblock_is_region_reserved(start, size)) {

It would be better to change >= to >.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/