| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131016090819.GC19112@lee--X1> Date: Wed, 16 Oct 2013 10:08:19 +0100 From: Lee Jones <lee.jones@...aro.org> To: Linus Walleij <linus.walleij@...aro.org> Cc: Samuel Ortiz <sameo@...ux.intel.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/5] mfd: tc3589x: add device tree bindings I'll let the DT guys do the deep review. Just a couple of small points from me though. 1. MFD patches have the following syntax: mfd: <device>[-sub]: <Description> /* Note the uppercase 'D' */ > This defines the device tree bindings for the Toshiba TC3589x > series of multi-purpose expanders. Only the stuff I can test > is defined: GPIO and keypad. Others may implement more > subdevices further down the road. > > Signed-off-by: Linus Walleij <linus.walleij@...aro.org> > --- > Documentation/devicetree/bindings/mfd/tc3589x.txt | 61 +++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/tc3589x.txt 2. The binding document is normally attached to the patch which applies the bindings, unless we've stopped doing that now. > + > +Example: > + 3. You left off the example? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists