linux-kernel - Re: [PATCH] perf: revert PERF_RECORD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131016093017.GD23440@gmail.com>
Date:	Wed, 16 Oct 2013 11:30:17 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"mingo@...e.hu" <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	David Ahern <dsahern@...il.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	Jiri Olsa <jolsa@...hat.com>, Hugh Dickins <hughd@...gle.com>
Subject: Re: [PATCH] perf: revert PERF_RECORD_MMAP2 support


* Stephane Eranian <eranian@...gle.com> wrote:

> > For example by a simple patch that returns -EINVAL (or -ENOSYS) if the 
> > new flag is used - i.e. behaves like the old kernel in that regard - 
> > but leaves the rest in place. (the 'rest' will hopefully be fixed for 
> > v3.13)
>
> That's what I did in my initial revert patch. But it did not include the 
> perf tool revert.

Could the perf tool part have a minimal revert as well?

> I believe in the end, we will still go with the extended MMAP record and 
> not with the physical address (which adds a PERF_SAMPLE_*). So we can 
> leave the attr->mmap2 bit defined and return -EINVAL for now.

Yeah.

> As for the perf tool, we can remove everything and add that later on 
> because the layout of the MMAP2 record may change.

Yes - but can we keep the actual revert patch minimal? I.e. just prevent 
mmap2 records from being generated, or so.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/