linux-kernel - Re: [PATCH] PM/AVS: SmartReflex: fix fake probe success on debugfs fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <525E9380.7090905@ti.com>
Date:	Wed, 16 Oct 2013 08:24:16 -0500
From:	Nishanth Menon <nm@...com>
To:	"Vishwanathrao Badarkhe, Manish" <manishv.b@...com>,
	<linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-omap@...r.kernel.org>
CC:	<khilman@...nel.org>, <anton@...msg.org>, <dwmw2@...radead.org>
Subject: Re: [PATCH] PM/AVS: SmartReflex: fix fake probe success on debugfs
 fail

On 10/16/2013 06:40 AM, Vishwanathrao Badarkhe, Manish wrote:
> From: "Vishwanathrao Badarkhe, Manish" <manishv.b@...com>
> 
> Currently, probe returns success(0) on "debugfs_create_dir"
> function call failed. Return proper error on "debugfs_create_dir"
> call failed.
> 
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@...com>
> ---
> Not tested on any EVM. Bug has been found while doing static review.
> Please confirm.


IMHO, fail of creation of debugfs is not reason enough to fail the
probe - further, this code needs a major revamp to work with device tree.

> 
> :100644 100644 db9973b... 7b101c1... M	drivers/power/avs/smartreflex.c
>  drivers/power/avs/smartreflex.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index db9973b..7b101c1 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -921,7 +921,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
>  	if (!sr_dbg_dir) {
>  		sr_dbg_dir = debugfs_create_dir("smartreflex", NULL);
>  		if (IS_ERR_OR_NULL(sr_dbg_dir)) {
> -			ret = PTR_ERR(sr_dbg_dir);
> +			ret = sr_dbg_dir ? PTR_ERR(sr_dbg_dir) : -EIO;
>  			pr_err("%s:sr debugfs dir creation failed(%d)\n",
>  				__func__, ret);
>  			goto err_list_del;
> @@ -932,7 +932,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
>  	if (IS_ERR_OR_NULL(sr_info->dbg_dir)) {
>  		dev_err(&pdev->dev, "%s: Unable to create debugfs directory\n",
>  			__func__);
> -		ret = PTR_ERR(sr_info->dbg_dir);
> +		ret = sr_info->dbg_dir ? PTR_ERR(sr_info->dbg_dir) : -EIO;
>  		goto err_debugfs;
>  	}
>  
> @@ -947,7 +947,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
>  	if (IS_ERR_OR_NULL(nvalue_dir)) {
>  		dev_err(&pdev->dev, "%s: Unable to create debugfs directory"
>  			"for n-values\n", __func__);
> -		ret = PTR_ERR(nvalue_dir);
> +		ret = nvalue_dir ? PTR_ERR(nvalue_dir) : -EIO;
>  		goto err_debugfs;
>  	}
>  
> 

-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/