linux-kernel - Re: [PATCH] Staging: comedi: fix semicolon coding style issue in ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Oct 2013 15:07:17 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Dhanunjaya <dhanunjaya.matrix@...il.com>,
	Ian Abbott <ian.abbott@....co.uk>,
	"hsweeten@...ionengravers.com" <hsweeten@...ionengravers.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"wfp5p@...ginia.edu" <wfp5p@...ginia.edu>
CC:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: comedi: fix semicolon coding style issue in
 ni_660x.c

On 2013-10-16 13:38, Dhanunjaya wrote:
> This is a patch to the ni_660x.c file that fixes up a semicolon warning
> found by the checkpatch.pl tool
> ---
>   drivers/staging/comedi/drivers/ni_660x.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c
> index 3607336..95bb432 100644
> --- a/drivers/staging/comedi/drivers/ni_660x.c
> +++ b/drivers/staging/comedi/drivers/ni_660x.c
> @@ -28,7 +28,7 @@
>    *
>    * Encoders work.  PulseGeneration (both single pulse and pulse train)
>    * works.  Buffered commands work for input but not output.
> - *
> + *
>    * References:
>    * DAQ 660x Register-Level Programmer Manual  (NI 370505A-01)
>    * DAQ 6601/6602 User Manual (NI 322137B-01)
> @@ -1232,7 +1232,7 @@ static int ni_660x_auto_attach(struct comedi_device *dev,
>   			s->type = COMEDI_SUBD_COUNTER;
>   			s->subdev_flags =
>   			    SDF_READABLE | SDF_WRITABLE | SDF_LSAMPL |
> -			    SDF_CMD_READ /* | SDF_CMD_WRITE */ ;
> +			    SDF_CMD_READ; /* | SDF_CMD_WRITE */
>   			s->n_chan = 3;
>   			s->maxdata = 0xffffffff;
>   			s->insn_read = ni_660x_GPCT_rinsn;
>

Looks good!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/