linux-kernel - Re: [PATCH] PM/AVS: SmartReflex: fix fake probe success on debugfs fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGo_u6rNJyzxtxn=0o-RC4487O+QuL5xE+vb+sP8_QxMg7g4yw@mail.gmail.com>
Date:	Wed, 16 Oct 2013 09:43:01 -0500
From:	Nishanth Menon <nm@...com>
To:	Manish Badarkhe <badarkhe.manish@...il.com>
Cc:	"Vishwanathrao Badarkhe, Manish" <manishv.b@...com>,
	linux-pm@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-omap <linux-omap@...r.kernel.org>, khilman@...nel.org,
	Anton Vorontsov <anton@...msg.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] PM/AVS: SmartReflex: fix fake probe success on debugfs fail

On Wed, Oct 16, 2013 at 9:24 AM, Manish Badarkhe
<badarkhe.manish@...il.com> wrote:
>
>>
>> IMHO, fail of creation of debugfs is not reason enough to fail the
>> probe - further, this code needs a major revamp to work with device tree.
>
> Yes, fail of debugfs creation should not be enough reason to fail probe. But as
> per current implementation of code, on debugfs failure smart reflex node is
> getting deleted and probe get failed. This patch not made any changes in
> logic of code but only makes proper use of  "IS_ERR_OR_NULL".

Thanks for the clarification, it was not obvious from the commit
message. Further, I would rather prefer to see a proper cleanup that
handles error completely, since IS_ERR_OR_NULL is not really
recommended anymore.
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/