linux-kernel - Re: [PATCH 1/2 linux-next] cifs: Remove redundant multiplex identifier check from check_smb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131016113632.6548d399@tlielax.poochiereds.net>
Date:	Wed, 16 Oct 2013 11:36:32 -0400
From:	Jeff Layton <jlayton@...hat.com>
To:	Tim Gardner <timg@....com>
Cc:	linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
	linux-kernel@...r.kernel.org, Steve French <sfrench@...ba.org>
Subject: Re: [PATCH 1/2 linux-next] cifs: Remove redundant multiplex
 identifier check from check_smb_hdr()

On Wed, 16 Oct 2013 09:09:49 -0600
Tim Gardner <timg@....com> wrote:

> The only call site for check_smb_header() assigns 'mid' from the SMB
> packet, which is then checked again in check_smb_header(). This seems
> like redundant redundancy.
> 
> Cc: Steve French <sfrench@...ba.org>
> Signed-off-by: Tim Gardner <timg@....com>
> ---
>  fs/cifs/misc.c |   12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
> index 138a011..298e31e 100644
> --- a/fs/cifs/misc.c
> +++ b/fs/cifs/misc.c
> @@ -278,7 +278,7 @@ header_assemble(struct smb_hdr *buffer, char smb_command /* command */ ,
>  }
>  
>  static int
> -check_smb_hdr(struct smb_hdr *smb, __u16 mid)
> +check_smb_hdr(struct smb_hdr *smb)
>  {
>  	/* does it have the right SMB "signature" ? */
>  	if (*(__le32 *) smb->Protocol != cpu_to_le32(0x424d53ff)) {
> @@ -287,13 +287,6 @@ check_smb_hdr(struct smb_hdr *smb, __u16 mid)
>  		return 1;
>  	}
>  
> -	/* Make sure that message ids match */
> -	if (mid != smb->Mid) {
> -		cifs_dbg(VFS, "Mids do not match. received=%u expected=%u\n",
> -			 smb->Mid, mid);
> -		return 1;
> -	}
> -
>  	/* if it's a response then accept */
>  	if (smb->Flags & SMBFLG_RESPONSE)
>  		return 0;
> @@ -310,7 +303,6 @@ int
>  checkSMB(char *buf, unsigned int total_read)
>  {
>  	struct smb_hdr *smb = (struct smb_hdr *)buf;
> -	__u16 mid = smb->Mid;
>  	__u32 rfclen = be32_to_cpu(smb->smb_buf_length);
>  	__u32 clc_len;  /* calculated length */
>  	cifs_dbg(FYI, "checkSMB Length: 0x%x, smb_buf_length: 0x%x\n",
> @@ -348,7 +340,7 @@ checkSMB(char *buf, unsigned int total_read)
>  	}
>  
>  	/* otherwise, there is enough to get to the BCC */
> -	if (check_smb_hdr(smb, mid))
> +	if (check_smb_hdr(smb))
>  		return -EIO;
>  	clc_len = smbCalcSize(smb);
>  

Nice...

Reviewed-by: Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/