linux-kernel - Re: [PATCH 1/3] perf tools: Add data object to handle perf data file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a9ia9biw.fsf@sejong.aot.lge.com>
Date:	Wed, 16 Oct 2013 11:48:07 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Ahern <dsahern@...il.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 1/3] perf tools: Add data object to handle perf data file

Hi Jiri,

On Tue, 15 Oct 2013 16:27:32 +0200, Jiri Olsa wrote:
> This patch is adding 'struct perf_data_file' object as
> a placeholder for all attributes regarding perf.data
> file handling. Changing perf_session__new to take it
> as an argument.
>
> The rest of the functionality will be added later to keep
> this change simple enough, because all the places using
> perf_session are changed now.

All three look good.

Btw, are you planning to support multiple per-cpu file record?  As you
know I suggested perf.data.dir approach in my perf-ftrace patchset (I'll
resend a new version soonish) something like below.  What do you think?

  perf.data.dir/
    |-- perf-cpu0.data
    |-- perf-cpu1.data
    |-- perf-cpu2.data
    `-- perf-cpu3.data

Maybe we could split sample data and other data (e.g. COMM, MMAP or some
user data?) to another file(s).

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/