linux-kernel - Re: [PATCH] ipc/sem.c: fix small codingstyle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Oct 2013 09:50:37 -0700
From:	Davidlohr Bueso <davidlohr@...com>
To:	Manfred Spraul <manfred@...orfullife.com>
Cc:	Joe Perches <joe@...ches.com>, Libin <huawei.libin@...wei.com>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	guohanjun@...wei.com, xiexiuqi@...wei.com
Subject: Re: [PATCH] ipc/sem.c: fix small codingstyle

On Wed, 2013-10-16 at 10:39 +0200, Manfred Spraul wrote:
> Hi Joe,
> 
> On 10/15/2013 08:36 PM, Joe Perches wrote:
> > On Tue, 2013-10-15 at 09:44 -0700, Davidlohr Bueso wrote:
> >> On Tue, 2013-10-15 at 16:19 +0800, Libin wrote:
> >>> From: Li Bin <huawei.libin@...wei.com>
> >>>
> >>> small codingstyle fix: '*' should be adjacent to the data name.
> >> There are *tons* of these, go crazy.
> >>
> > Here are the whitespace changes proposed by
> > $ scripts/checkpatch -f --fix --types=pointer_location,spacing,space_before_tab ipc/*.[ch]
> /me hides, probably most of them are mine.
> 
> Davidlohr: Do you have anything outstanding for ipc/*.c?
> I have nothing.

Nope.

> 
> My proposal would be that the checkpatch -f patch should be added for 
> 3.14, i.e. let's give the code one more cycle to calm down.

I think it would be fine for the 3.13 merge window, but considering all
the action for this release, I have no problem waiting longer.

> Grek just sent me 47 patches for the backport to 3.10-stable, I don't 
> want any whitespace noise right now.

+1

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/