linux-kernel - Re: [PATCH v2 8/9] ACPI, APEI, CPER: Cleanup CPER memory error output format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131016172410.GM13608@pd.tnic>
Date:	Wed, 16 Oct 2013 19:24:10 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	"Chen, Gong" <gong.chen@...ux.intel.com>
Cc:	tony.luck@...el.com, joe@...ches.com,
	naveen.n.rao@...ux.vnet.ibm.com, m.chehab@...sung.com,
	arozansk@...hat.com, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 8/9] ACPI, APEI, CPER: Cleanup CPER memory error
 output format

On Wed, Oct 16, 2013 at 10:56:05AM -0400, Chen, Gong wrote:
> Keep up only the most important fields for memory error
> reporting. The detail information will be moved to perf/trace
> interface.
> 
> Suggested-by: Tony Luck <tony.luck@...el.com>
> Signed-off-by: Chen, Gong <gong.chen@...ux.intel.com>
> ---
>  drivers/acpi/apei/cper.c | 69 +++++++++++++++++++++++-------------------------
>  1 file changed, 33 insertions(+), 36 deletions(-)
> 
> diff --git a/drivers/acpi/apei/cper.c b/drivers/acpi/apei/cper.c
> index b1a8a55..f5bc227 100644
> --- a/drivers/acpi/apei/cper.c
> +++ b/drivers/acpi/apei/cper.c
> @@ -33,6 +33,9 @@
>  #include <linux/pci.h>
>  #include <linux/aer.h>
>  
> +#define INDENT_SP	" "
> +#define HW_CE_INFO \
> +	"Above error has been corrected by h/w and no further action required"

Leftover?


> +	if (severity != CPER_SEV_FATAL)
> +		printk("%s%s\n", pfx,
> +		       "Above error has been corrected by h/w "
> +		       "and require no further action");

Let's write it out and correct grammar:

"Above error has been corrected by the hardware and requires no further action."

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/