linux-kernel - Re: [PATCH 1/4] Staging: comedi: fix semicolon coding style issue in ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Oct 2013 12:34:44 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Dhanunjaya Naidu Ravada <dhanunjaya.matrix@...il.com>
Cc:	abbotti@....co.uk, hsweeten@...ionengravers.com,
	wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] Staging: comedi: fix semicolon coding style issue in
 ni_660x.c

On Thu, Oct 17, 2013 at 12:54:52AM +0530, Dhanunjaya Naidu Ravada wrote:
> From: Dhanunjaya <dhanunjaya.matrix@...il.com>

Again, doesn't match the signed-off-by: or From: line on your email :(

> This is a patch to the ni_660x.c file that fixes up a semicolon warning
> found by the checkpatch.pl tool.

No it isn't, it also does something else in this file.

> 
> Signed-off-by: Dhanunjaya Naidu Ravada <dhanunjaya.matrix@...il.com>
> ---
>  drivers/staging/comedi/drivers/ni_660x.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c
> index 3607336..95bb432 100644
> --- a/drivers/staging/comedi/drivers/ni_660x.c
> +++ b/drivers/staging/comedi/drivers/ni_660x.c
> @@ -28,7 +28,7 @@
>   *
>   * Encoders work.  PulseGeneration (both single pulse and pulse train)
>   * works.  Buffered commands work for input but not output.
> - * 
> + *

That doesn't look like a semicolon fix.

>   * References:
>   * DAQ 660x Register-Level Programmer Manual  (NI 370505A-01)
>   * DAQ 6601/6602 User Manual (NI 322137B-01)
> @@ -1232,7 +1232,7 @@ static int ni_660x_auto_attach(struct comedi_device *dev,
>  			s->type = COMEDI_SUBD_COUNTER;
>  			s->subdev_flags =
>  			    SDF_READABLE | SDF_WRITABLE | SDF_LSAMPL |
> -			    SDF_CMD_READ /* | SDF_CMD_WRITE */ ;
> +			    SDF_CMD_READ; /* | SDF_CMD_WRITE */

Nope, please leave the original code, it's correct.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/