linux-kernel - Re: [PATCH v2 5/5] drivers: usb: core: devio.c: Put arguments on new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131016204044.GB6701@kroah.com>
Date:	Wed, 16 Oct 2013 13:40:44 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Matthias Beyer <mail@...ermatthias.de>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] drivers: usb: core: devio.c: Put arguments on new
 line

On Mon, Oct 14, 2013 at 09:46:40PM +0200, Matthias Beyer wrote:
> To fit the 80-cols convention, this patch moves the arguments (the
> second and third one) for driver->unlocked_ioctl() onto a new line.
> 
> Signed-off-by: Matthias Beyer <mail@...ermatthias.de>
> ---
>  drivers/usb/core/devio.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index 9761a27..0387948 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -1870,7 +1870,8 @@ static int proc_ioctl(struct dev_state *ps, struct usbdevfs_ioctl *ctl)
>  			if (driver == NULL || driver->unlocked_ioctl == NULL) {
>  				retval = -ENOTTY;
>  			} else {
> -				retval = driver->unlocked_ioctl(intf, ctl->ioctl_code, buf);
> +				retval = driver->unlocked_ioctl(intf,
> +						ctl->ioctl_code, buf);

Nah, it looks worse this way, just leave it alone.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/