linux-kernel - Re: [PATCH 5/5] sched: Avoid throttle_cfs_rq racing with period

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131016220609.GN10651@twins.programming.kicks-ass.net>
Date:	Thu, 17 Oct 2013 00:06:09 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ben Segall <bsegall@...gle.com>
Cc:	mingo@...hat.com, pjt@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] sched: Avoid throttle_cfs_rq racing with
 period_timer stopping

On Wed, Oct 16, 2013 at 11:16:32AM -0700, Ben Segall wrote:
> +#ifdef CONFIG_CFS_BANDWIDTH
> +	SEQ_printf(m, "  .%-30s: %d\n", "tg->cfs_bandwidth.timer_active",
> +			cfs_rq->tg->cfs_bandwidth.timer_active);
> +	SEQ_printf(m, "  .%-30s: %d\n", "throttled",
> +			cfs_rq->throttled);
> +	SEQ_printf(m, "  .%-30s: %d\n", "throttle_count",
> +			cfs_rq->throttle_count);
> +#endif

Not really your fault; but that function just cries for something like:

#define SEQ_cfs_rq(m, member)		\
	SEQ_printf(m, "  .%-30s: %ld\n", #member, (long)cfs_rq->member)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/