linux-kernel - Re: [PATCH] virtio tools: use ansi versions of asm and volatile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Oct 2013 10:39:09 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Ramkumar Ramachandra <artagnon@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Cc:	"Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH] virtio tools: use ansi versions of asm and volatile

Ramkumar Ramachandra <artagnon@...il.com> writes:
> asm and volatile are provided for backward compatibility; use the ansi
> versions __asm__ and __volatile__.

Really?  I don't see that in the gcc documentation.  In fact, I didn't
know __volatile__ at all:

 If you are writing a header file that should be includable in ISO C
 programs, write `__asm__' instead of `asm'.  *Note Alternate Keywords::.

We're not...

Cheers,
Rusty.

> Cc: Rusty Russell <rusty@...tcorp.com.au>
> Cc: Michael S. Tsirkin <mst@...hat.com>
> Signed-off-by: Ramkumar Ramachandra <artagnon@...il.com>
> ---
>  tools/virtio/asm/barrier.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtio/asm/barrier.h b/tools/virtio/asm/barrier.h
> index aff61e1..b2fbbfc 100644
> --- a/tools/virtio/asm/barrier.h
> +++ b/tools/virtio/asm/barrier.h
> @@ -1,5 +1,5 @@
>  #if defined(__i386__) || defined(__x86_64__)
> -#define barrier() asm volatile("" ::: "memory")
> +#define barrier() __asm__ __volatile__("" ::: "memory")
>  #define mb() __sync_synchronize()
>  
>  #define smp_mb()	mb()
> -- 
> 1.8.4.477.g5d89aa9
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/