linux-kernel - Re: [PATCH 02/12] mm, thp, tmpfs: support to add huge page into page cache for tmpfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Oct 2013 16:20:23 -0700
From:	Ning Qu <quning@...gle.com>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:	Andrea Arcangeli <aarcange@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Wu Fengguang <fengguang.wu@...el.com>, Jan Kara <jack@...e.cz>,
	Mel Gorman <mgorman@...e.de>, linux-mm@...ck.org,
	Andi Kleen <ak@...ux.intel.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Hillf Danton <dhillf@...il.com>, Dave Hansen <dave@...1.net>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/12] mm, thp, tmpfs: support to add huge page into page
 cache for tmpfs

Consider this fixed. I have extracted the common function and the new
shmem_insert_page_page_cache function looks like this:

       spin_lock_irq(&mapping->tree_lock);
       error = __add_to_page_cache_locked(page, mapping, index);

       if (!error)
            __mod_zone_page_state(page_zone(page), NR_SHMEM, nr);

        radix_tree_preload_end();
        spin_unlock_irq(&mapping->tree_lock);

        if (error)
                page_cache_release(page);

        return error;
Best wishes,
-- 
Ning Qu (曲宁) | Software Engineer | quning@...gle.com | +1-408-418-6066


On Wed, Oct 16, 2013 at 10:49 AM, Ning Qu <quning@...gle.com> wrote:
> Yes, I guess I can if I just put whatever inside the spin lock into a
> common function. Thanks!
> Best wishes,
> --
> Ning Qu (曲宁) | Software Engineer | quning@...gle.com | +1-408-418-6066
>
>
> On Wed, Oct 16, 2013 at 5:26 AM, Kirill A. Shutemov
> <kirill.shutemov@...ux.intel.com> wrote:
>> Ning Qu wrote:
>>> Yes, I can try. The code is pretty much similar with some minor difference.
>>>
>>> One thing I can do is to move the spin lock part (together with the
>>> corresponding err handling into a common function.
>>>
>>> The only problem I can see right now is we need the following
>>> additional line for shm:
>>>
>>> __mod_zone_page_state(page_zone(page), NR_SHMEM, nr);
>>>
>>> Which means we need to tell if it's coming from shm or not, is that OK
>>> to add additional parameter just for that? Or is there any other
>>> better way we can infer that information? Thanks!
>>
>> I think you can account NR_SHMEM after common code succeed, don't you?
>>
>> --
>>  Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/