linux-kernel - Re: [PATCH v2 3/9] bitops: Introduce a more generic BITMASK macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131017084014.GD5036@pd.tnic>
Date:	Thu, 17 Oct 2013 10:40:14 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Joe Perches <joe@...ches.com>
Cc:	Chen Gong <gong.chen@...ux.intel.com>, tony.luck@...el.com,
	naveen.n.rao@...ux.vnet.ibm.com, m.chehab@...sung.com,
	arozansk@...hat.com, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Thomas Winischhofer <thomas@...ischhofer.net>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>
Subject: Re: [PATCH v2 3/9] bitops: Introduce a more generic BITMASK macro

On Thu, Oct 17, 2013 at 01:32:30AM -0700, Joe Perches wrote:
> On Thu, 2013-10-17 at 03:38 -0400, Chen Gong wrote:
> > the point is we can use GENMASK like GENMASK(end_bit, start_bit) but
> > we don't know the value of end_bit/start_bit at compile-time.
> 
> True.
> 
> The BUILD_BUG_ON idea is just to avoid people using
> 	GENMASK(1, 2)

They'll notice the 0 pretty quickly when they test their code.

Let's add those checks only when it is really necessary and people have
actually made that mistake repeatedly.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/