lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-Id: <1382007130-20208-1-git-send-email-tomas.winkler@intel.com>
Date:	Thu, 17 Oct 2013 13:52:10 +0300
From:	Tomas Winkler <tomas.winkler@...el.com>
To:	gregkh@...uxfoundation.org
Cc:	arnd@...db.de, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Paul Bolle <pebolle@...cali.nl>,
	Adam Jackson <ajax@...hat.com>, Joe Perches <joe@...ches.com>,
	Tomas Winkler <tomas.winkler@...el.com>
Subject: [char-misc-next V3] mei: me: downgrade two errors to debug level

From: Paul Bolle <pebolle@...cali.nl>

The mei_me driver prints "suspend" at error level at each suspend. It
also prints "stop" at error level at driver unload. Downgrade these
uninteresting messages to debug level.

Cc: Adam Jackson <ajax@...hat.com>
Cc: Joe Perches <joe@...ches.com>
Signed-off-by: Paul Bolle <pebolle@...cali.nl>
Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
---
0) v1 was called "mei: me: downgrade "suspend" message to debug level".

V2 also downgrades the "stop" message.

1) Added Adam and Joe to Cc:. They were involved in discussing a patch
 by Adam, which was similar to my v1, about a week ago.

2) Still lightly tested only, but now on top of v3.11.1.
V3: RESEND, it was not merged

 drivers/misc/mei/pci-me.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index d2ea9ff..1bf300e 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -232,7 +232,7 @@ static void mei_me_remove(struct pci_dev *pdev)
 	hw = to_me_hw(dev);
 
 
-	dev_err(&pdev->dev, "stop\n");
+	dev_dbg(&pdev->dev, "stop\n");
 	mei_stop(dev);
 
 	/* disable interrupts */
@@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
 	if (!dev)
 		return -ENODEV;
 
-	dev_err(&pdev->dev, "suspend\n");
+	dev_dbg(&pdev->dev, "suspend\n");
 
 	mei_stop(dev);
 
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ