linux-kernel - Re: [PATCH] ecryptfs: Fix memory leakage in keystore.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGG-pUQbCMz6GJEOJUPnLA-+dbrUB=E81P9yjvT6EEysdNzSEA@mail.gmail.com>
Date:	Wed, 16 Oct 2013 22:21:46 -0300
From:	Geyslan Gregório Bem <geyslan@...il.com>
To:	Tyler Hicks <tyhicks@...onical.com>
Cc:	ecryptfs@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Joe Perches <joe@...ches.com>,
	kernel-br <kernel-br@...glegroups.com>
Subject: Re: [PATCH] ecryptfs: Fix memory leakage in keystore.c

2013/10/16 Tyler Hicks <tyhicks@...onical.com>:
> On 2013-10-11 16:49:16, Geyslan G. Bem wrote:
>> In 'decrypt_pki_encrypted_session_key' function:
>>
>> Initializes 'payload' pointer and releases it on exit.
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
>> ---
>
> Thanks! This one was easy to verify by auditing the code, but I was also
> able to verify the leak with kmemleak.
It's a pleasure.

>
> I've targeted it for stable and pushed it to the eCryptfs next branch.
>
Thank you.

> Tyler
>
>>  fs/ecryptfs/keystore.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
>> index 7d52806..4725a07 100644
>> --- a/fs/ecryptfs/keystore.c
>> +++ b/fs/ecryptfs/keystore.c
>> @@ -1149,7 +1149,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
>>       struct ecryptfs_msg_ctx *msg_ctx;
>>       struct ecryptfs_message *msg = NULL;
>>       char *auth_tok_sig;
>> -     char *payload;
>> +     char *payload = NULL;
>>       size_t payload_len = 0;
>>       int rc;
>>
>> @@ -1203,6 +1203,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
>>       }
>>  out:
>>       kfree(msg);
>> +     kfree(payload);
>>       return rc;
>>  }
>>
>> --
>> 1.8.4
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/