| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131017122647.GC6862@nuc-i3427.alporthouse.com> Date: Thu, 17 Oct 2013 13:26:47 +0100 From: Chris Wilson <chris@...is-wilson.co.uk> To: Pavel Roskin <proski@....org> Cc: Dave Airlie <airlied@...hat.com>, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org Subject: Re: [PATCH] drm: never write to the userspace more data than the caller wants On Wed, Oct 16, 2013 at 08:12:35PM -0400, Pavel Roskin wrote: > The amount of data wanted by the userspace caller is encoded in the > ioctl number. Generic drm ioctls were ignoring it. > > As a result, Intel Xorg driver didn't work for i386 userspace on x86_64 > kernel on some systems. sizeof(struct drm_mode_get_connector) is 76 > bytes on i686 and 80 bytes on x86_64 due to the tail alignment (the data > positions match). The userspace was using the 4 bytes after the > structure to hold the result of the ioctl. Since drm_ioctl() was > copying 80 bytes instead of 76, it was clobbering that data. > > A workaround has been committed to xf86-video-intel. > > Signed-off-by: Pavel Roskin <proski@....org> > Cc: stable@...r.kernel.org Similar patch: http://lists.freedesktop.org/archives/dri-devel/2013-October/047412.html -Chris -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists