linux-kernel - Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <525FE728.90403@metafoo.de>
Date:	Thu, 17 Oct 2013 15:33:28 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Timur Tabi <timur@...i.org>
CC:	Xiubo Li <Li.Xiubo@...escale.com>, r65073@...escale.com,
	lgirdwood@...il.com, broonie@...nel.org, mark.rutland@....com,
	alsa-devel@...a-project.org, linux-doc@...r.kernel.org,
	tiwai@...e.de, b18965@...escale.com, LW@...O-electronics.de,
	linux@....linux.org.uk, b42378@...escale.com, oskar@...ra.com,
	grant.likely@...aro.org, devicetree@...r.kernel.org,
	ian.campbell@...rix.com, pawel.moll@....com, swarren@...dotorg.org,
	rob.herring@...xeda.com, linux-arm-kernel@...ts.infradead.org,
	fabio.estevam@...escale.com, linux-kernel@...r.kernel.org,
	rob@...dley.net, r64188@...escale.com, shawn.guo@...aro.org,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface
 driver.

On 10/17/2013 03:22 PM, Timur Tabi wrote:
> Lars-Peter Clausen wrote:
>>>> >>+    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>>> >>+    sai->base = devm_ioremap_resource(&pdev->dev, res);
>>> >
>>> >Why not use of_iomap()?
>> Because it won't check for conflicting resource regions.
> 
> Maybe I've been out of the loop for too long, but why is that a particular
> problem with this driver?

It is usually something you'd want to check in general to make sure that you
don't have multiple device that access the same iomem region at the same time.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/