linux-kernel - Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131017141003.GO2443@sirena.org.uk>
Date:	Thu, 17 Oct 2013 15:10:03 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Timur Tabi <timur@...i.org>, Xiubo Li <Li.Xiubo@...escale.com>,
	r65073@...escale.com, lgirdwood@...il.com, mark.rutland@....com,
	alsa-devel@...a-project.org, linux-doc@...r.kernel.org,
	tiwai@...e.de, b18965@...escale.com, LW@...O-electronics.de,
	linux@....linux.org.uk, b42378@...escale.com, oskar@...ra.com,
	grant.likely@...aro.org, devicetree@...r.kernel.org,
	ian.campbell@...rix.com, pawel.moll@....com, swarren@...dotorg.org,
	rob.herring@...xeda.com, linux-arm-kernel@...ts.infradead.org,
	fabio.estevam@...escale.com, linux-kernel@...r.kernel.org,
	rob@...dley.net, r64188@...escale.com, shawn.guo@...aro.org,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio
 Interface driver.

On Thu, Oct 17, 2013 at 03:51:54PM +0200, Lars-Peter Clausen wrote:
> On 10/17/2013 03:37 PM, Timur Tabi wrote:

> > I understand that, but I'm trying to figure out why of_iomap() is okay for
> > hundreds of other drivers, but not this one.  I've used it dozens of times
> > myself, without ever worrying about overlapping regions.

> The driver would work fine with just of_iomap(). But the resource range
> check comes basically for free and it does help to catch errors, so I'd
> recommend on using it rather than not using it.

There's also the fact that it's a devm_ function which means less error
handling code that we can break which is nice.  There's probably a case
for an improved OF helper here...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)