linux-kernel - Re: [PATCH -next] misc: fix various misc/mic/host/ build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131017141534.GA22319@kroah.com>
Date:	Thu, 17 Oct 2013 07:15:34 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Randy Dunlap <rdunlap@...radead.org>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
	Harshavardhan R Kharche <harshavardhan.r.kharche@...el.com>,
	Ashutosh Dixit <ashutosh.dixit@...el.com>,
	Nikhil Rao <nikhil.rao@...el.com>,
	Sudeep Dutt <sudeep.dutt@...el.com>
Subject: Re: [PATCH -next] misc: fix various misc/mic/host/ build errors

On Thu, Oct 17, 2013 at 04:02:25PM +0200, Thierry Reding wrote:
> On Wed, Oct 16, 2013 at 01:37:27PM -0700, Greg Kroah-Hartman wrote:
> > On Wed, Oct 16, 2013 at 10:30:25PM +0200, Thierry Reding wrote:
> > > On Wed, Oct 16, 2013 at 12:44:40PM -0700, Greg Kroah-Hartman wrote:
> > > > On Wed, Oct 16, 2013 at 12:41:08PM -0700, Randy Dunlap wrote:
> > > > > On 10/16/13 12:26, Greg Kroah-Hartman wrote:
> > > > > > On Mon, Oct 14, 2013 at 12:38:06PM -0700, Randy Dunlap wrote:
> > > > > >> From: Randy Dunlap <rdunlap@...radead.org>
> > > > > >>
> > > > > >> Fix various build errors (on x86_64) for drivers/misc/mic/host/:
> > > > > >>
> > > > > >>   drivers/misc/mic/host/mic_main.c:378:3: error: too many arguments to function 'sysfs_get_dirent'
> > > > > >>   drivers/misc/mic/host/mic_intr.h:134:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
> > > > > >>   drivers/misc/mic/host/mic_intr.h:134:58: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> > > > > >>   drivers/misc/mic/host/mic_intr.h:135:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
> > > > > >>   drivers/misc/mic/host/mic_device.h:169:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
> > > > > >>   drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_read':
> > > > > >>   drivers/misc/mic/host/mic_device.h:169:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
> > > > > >>   drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_write':
> > > > > >>   drivers/misc/mic/host/mic_device.h:183:2: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration]
> > > > > >>
> > > > > >> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > > > > >> Cc: Harshavardhan R Kharche <harshavardhan.r.kharche@...el.com>
> > > > > >> Cc: Ashutosh Dixit <ashutosh.dixit@...el.com>
> > > > > >> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > > > >> Cc: Nikhil Rao <nikhil.rao@...el.com>
> > > > > >> Cc: Sudeep Dutt <sudeep.dutt@...el.com>
> > > > > > 
> > > > > > This is a -next issue only at this point in time, I thought it was in
> > > > > > the -next tree as a "fixup" already?
> > > > > 
> > > > > Are you asking the driver maintainers?
> > > > 
> > > > No, the linux-next maintainers.
> > > > 
> > > > The driver maintainers have nothing to do with this, it's a sysfs change
> > > > in my driver-core tree that causes this issue.
> > > 
> > > Well, we do carry a patch to fix this, but that generally doesn't get
> > > carried to Linus' tree automatically as far as I know. So I guess it's
> > > fine for now, but when the merge window opens you'll need to make sure
> > > that Linus merges the branches in the correct order so that the build
> > > doesn't break in between.
> > 
> > Yes, I'll do that as part of my normal tree submission process.
> 
> Actually, ensuring correct merge order won't be enough, will it? That
> doesn't magically fixes that the function's signature actually changed.
> 
> Shouldn't the update of the sysfs_get_dirent() call be fixed within the
> same patch that updates the sysfs_get_dirent() signature?

Yes, _if_ those files are actually part of that tree, but they aren't
(they got added in my staging-next tree, while these sysfs changes are
in my driver-next tree.)

So the trees on their own build just fine, it's only when you merge them
that there is an issue.  This happens all the time when apis change,
nothing new here...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/