linux-kernel - Re: [PATCH v2 3/9] bitops: Introduce a more generic BITMASK macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Oct 2013 22:31:49 -0400
From:	Chen Gong <gong.chen@...ux.intel.com>
To:	Mauro Carvalho Chehab <m.chehab@...sung.com>
Cc:	tony.luck@...el.com, bp@...en8.de, joe@...ches.com,
	naveen.n.rao@...ux.vnet.ibm.com, arozansk@...hat.com,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Thomas Winischhofer <thomas@...ischhofer.net>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>
Subject: Re: [PATCH v2 3/9] bitops: Introduce a more generic BITMASK macro

On Wed, Oct 16, 2013 at 02:02:21PM -0300, Mauro Carvalho Chehab wrote:
> Date: Wed, 16 Oct 2013 14:02:21 -0300
> From: Mauro Carvalho Chehab <m.chehab@...sung.com>
> To: "Chen, Gong" <gong.chen@...ux.intel.com>
> Cc: tony.luck@...el.com, bp@...en8.de, joe@...ches.com,
>  naveen.n.rao@...ux.vnet.ibm.com, arozansk@...hat.com,
>  linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, Thomas
>  Winischhofer <thomas@...ischhofer.net>, Jean-Christophe Plagniol-Villard
>  <plagnioj@...osoft.com>, Tomi Valkeinen <tomi.valkeinen@...com>
> Subject: Re: [PATCH v2 3/9] bitops: Introduce a more generic BITMASK macro
> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.19; x86_64-redhat-linux-gnu)
> 
> Em Wed, 16 Oct 2013 10:56:00 -0400
> "Chen, Gong" <gong.chen@...ux.intel.com> escreveu:
> 
> > GENMASK is used to create a contiguous bitmask([hi:lo]). It is
> > implemented twice in current kernel. One is in EDAC driver, the other
> > is in SiS/XGI FB driver. Move it to a more generic place for other
> > usage.
> > 
> > Signed-off-by: Chen, Gong <gong.chen@...ux.intel.com>
> > Cc: Borislav Petkov <bp@...en8.de>
> > Cc: Thomas Winischhofer <thomas@...ischhofer.net>
> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
> > Cc: Tomi Valkeinen <tomi.valkeinen@...com>
> 
> Acked-by: Mauro Carvalho Chehab <m.chehab@...sung.com>
> 
> Btw, there's another incarnation of it at sb_edac.c (GET_BITFIELD).
> It could make sense to also replace it by the newly bitops.h macro.
> 
> Regards,
> Mauro

Aha, I will update it in the next version.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)