linux-kernel - Re: [PATCH 2/8] [media] exynos4-is: Don't use i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <20131017144604.1d649988@samsung.com>
Date:	Thu, 17 Oct 2013 14:46:04 -0300
From:	Mauro Carvalho Chehab <m.chehab@...sung.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Wolfram Sang <wsa@...-dreams.de>, David Airlie <airlied@...ux.ie>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	linux-i2c@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	linux-media@...r.kernel.org, alsa-devel@...a-project.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>
Subject: Re: [PATCH 2/8] [media] exynos4-is: Don't use i2c_client->driver

Em Sun, 29 Sep 2013 10:51:00 +0200
Lars-Peter Clausen <lars@...afoo.de> escreveu:

> The 'driver' field of the i2c_client struct is redundant and is going to be
> removed. The results of the expressions 'client->driver.driver->field' and
> 'client->dev.driver->field' are identical, so replace all occurrences of the
> former with the later.
> 
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Kyungmin Park <kyungmin.park@...sung.com>
> Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>

Acked-by: Mauro Carvalho Chehab <m.chehab@...sung.com>

> ---
>  drivers/media/platform/exynos4-is/media-dev.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
> index a835112..7a4ee4c 100644
> --- a/drivers/media/platform/exynos4-is/media-dev.c
> +++ b/drivers/media/platform/exynos4-is/media-dev.c
> @@ -411,8 +411,8 @@ static int fimc_md_of_add_sensor(struct fimc_md *fmd,
>  
>  	device_lock(&client->dev);
>  
> -	if (!client->driver ||
> -	    !try_module_get(client->driver->driver.owner)) {
> +	if (!client->dev.driver ||
> +	    !try_module_get(client->dev.driver->owner)) {
>  		ret = -EPROBE_DEFER;
>  		v4l2_info(&fmd->v4l2_dev, "No driver found for %s\n",
>  						node->full_name);
> @@ -442,7 +442,7 @@ static int fimc_md_of_add_sensor(struct fimc_md *fmd,
>  	fmd->num_sensors++;
>  
>  mod_put:
> -	module_put(client->driver->driver.owner);
> +	module_put(client->dev.driver->owner);
>  dev_put:
>  	device_unlock(&client->dev);
>  	put_device(&client->dev);


-- 

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/