linux-kernel - Re: [PATCH v4 05/15] clk: tegra: move some PLLC and PLLXC init to clk-pll.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Oct 2013 15:33:13 -0700
From:	Andrew Bresticker <abrestic@...omium.org>
To:	Peter De Schrijver <pdeschrijver@...dia.com>
Cc:	Prashant Gaikwad <pgaikwad@...dia.com>,
	Mike Turquette <mturquette@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Thierry Reding <thierry.reding@...il.com>,
	linux-tegra@...r.kernel.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 05/15] clk: tegra: move some PLLC and PLLXC init to clk-pll.c

Hi Peter,

> +       val = readl_relaxed(clk_base + pll_params->base_reg);
> +       val_iddq = readl_relaxed(clk_base + pll_params->iddq_reg);
> +
> +       if (val & BIT(30))

BIT(30) -> PLL_BASE_ENABLE?

> +               WARN_ON(val_iddq & BIT(pll_params->iddq_bit_idx));
> +       else {
> +               val_iddq |= BIT(pll_params->iddq_bit_idx);
> +               writel_relaxed(val_iddq, clk_base + pll_params->iddq_reg);
> +       }

Thanks,
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/