linux-kernel - [PATCH] scripts/kernel-doc: make unknown function prototype a Warning instead of an Error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <52607371.3060805@infradead.org>
Date:	Thu, 17 Oct 2013 16:32:01 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Rob Landley <rob@...dley.net>, Michal Marek <mmarek@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nel.org>
Subject: [PATCH] scripts/kernel-doc: make unknown function prototype a Warning
 instead of an Error

From: Randy Dunlap <rdunlap@...radead.org>

When scripts/kernel-doc cannot understand a function prototype,
it had been generating a fatal error and stopping immediately.
Make this a Warning instead of an Error and keep going.

Note that this can happen if the kernel-doc notation that is being
parsed is not actually a function prototype; maybe it's a struct or
something else, so I added "function" to the warning message to try
to make it clearer that scripts/kernel-doc is looking for a function
prototype here.

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc:	Mark Brown <broonie@...nel.org>
---
 scripts/kernel-doc |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- linux-3.12-rc5.orig/scripts/kernel-doc
+++ linux-3.12-rc5/scripts/kernel-doc
@@ -2125,8 +2125,7 @@ sub dump_function($$) {
 
 	create_parameterlist($args, ',', $file);
     } else {
-	print STDERR "Error(${file}:$.): cannot understand prototype: '$prototype'\n";
-	++$errors;
+	print STDERR "Warning(${file}:$.): cannot understand function prototype: '$prototype'\n";
 	return;
     }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/