linux-kernel - Re: [PATCH] genirq: error reporting for non-percpu interrupt in request_percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Oct 2013 15:39:08 +0530
From:	Vinayak Kale <vkale@....com>
To:	linux-kernel <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Cc:	tglx <tglx@...utronix.de>, Will Deacon <will.deacon@....com>,
	Vinayak Kale <vkale@....com>
Subject: Re: [PATCH] genirq: error reporting for non-percpu interrupt in request_percpu_irq()

Need for this patch is discussed in mail-thread [1].

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-October/204414.html

Thanks
-Vinayak

On Fri, Oct 18, 2013 at 3:36 PM, Vinayak Kale <vkale@....com> wrote:
> Return a separate error code when a non-percpu interrupt is passed to
> request_percpu_irq().
>
> Suggested-by: Will Deacon <will.deacon@....com>
> Signed-off-by: Vinayak Kale <vkale@....com>
> ---
>  kernel/irq/manage.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 514bcfd..c2713ae 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -1671,10 +1671,12 @@ int request_percpu_irq(unsigned int irq, irq_handler_t handler,
>                 return -EINVAL;
>
>         desc = irq_to_desc(irq);
> -       if (!desc || !irq_settings_can_request(desc) ||
> -           !irq_settings_is_per_cpu_devid(desc))
> +       if (!desc || !irq_settings_can_request(desc))
>                 return -EINVAL;
>
> +       if (!irq_settings_is_per_cpu_devid(desc))
> +               return -EPERM;
> +
>         action = kzalloc(sizeof(struct irqaction), GFP_KERNEL);
>         if (!action)
>                 return -ENOMEM;
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/