linux-kernel - Re: [PATCH v4 03/15] clk: tegra: common periph_clk_enb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131018121829.GA25591@tbergstrom-lnx.Nvidia.com>
Date:	Fri, 18 Oct 2013 15:18:29 +0300
From:	Peter De Schrijver <pdeschrijver@...dia.com>
To:	Andrew Bresticker <abrestic@...omium.org>
CC:	Prashant Gaikwad <pgaikwad@...dia.com>,
	Mike Turquette <mturquette@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 03/15] clk: tegra: common periph_clk_enb_refcnt and
 clks

On Fri, Oct 18, 2013 at 12:26:20AM +0200, Andrew Bresticker wrote:
> Hi Peter,
> 
> >  static void __init tegra30_clock_init(struct device_node *np)
> >  {
> >         struct device_node *node;
> > -       int i;
> >
> >         clk_base = of_iomap(np, 0);
> >         if (!clk_base) {
> > @@ -1916,8 +1910,11 @@ static void __init tegra30_clock_init(struct device_node *np)
> >                 BUG();
> >         }
> >
> > -       if (tegra_clk_set_periph_banks(5) < 0)
> > +       clks = tegra_clk_init(clk_max, 5);
> > +       if (!clks) {
> > +               WARN_ON(1);
> 
> Really minor nit: it seems strange that we WARN here for t30, but not
> for t114 or t20.

There used to be a warning for all 3, but I removed it and apparently forgot
t30.

Cheers,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/