linux-kernel - Re: [PATCH 07/19] perf script: Set up output options for in-stream attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <526137E5.3050803@gmail.com>
Date:	Fri, 18 Oct 2013 07:30:13 -0600
From:	David Ahern <dsahern@...il.com>
To:	Adrian Hunter <adrian.hunter@...el.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
CC:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 07/19] perf script: Set up output options for in-stream
 attributes

On 10/18/13 6:29 AM, Adrian Hunter wrote:
> Attributes (struct perf_event_attr) are recorded
> separately in the perf.data file.  perf script uses
> them to set up output options.  However attributes
> can also be in the event stream, for example when
> the input is a pipe (i.e. live mode).  This patch
> makes perf script process in-stream attributes in
> the same way as on-file attributes.

You have multiple changes in this patch -- expanding attribute 
processing to set output options per the description above and you are 
also making perf_script a stack variable. The latter should be a 
separate patch.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/