linux-kernel - [PATCH v2 00/13] dmaengine: introduce dmaengine_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-id: <1382117733-16720-1-git-send-email-b.zolnierkie@samsung.com>
Date:	Fri, 18 Oct 2013 19:35:20 +0200
From:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:	dan.j.williams@...el.com
Cc:	vinod.koul@...el.com, dave.jiang@...el.com, t.figa@...sung.com,
	kyungmin.park@...sung.com, linux@....linux.org.uk,
	linux-kernel@...r.kernel.org, b.zolnierkie@...sung.com
Subject: [PATCH v2 00/13] dmaengine: introduce dmaengine_unmap_data

[ Original patch series description by Dan. ]

dmaengine from the beginning has placed the burden of unmapping dma
buffers on the individual drivers.  The thought being that since the dma
driver already has the descriptor it can use that information for
unmapping.  This results in a lot of cruft to read back data from
descriptors, places a burden on channels that need to break up an
operation internally into multiple descriptors, and makes it difficult
to have dma mappings with different lifetimes than the current
operation.

For example an xor->copy->xor chain wants to leave all buffers
mapped until completion, async_tx currently performs invalid overlapping
mappings.  With dmaengine_unmap_data map once and take a reference for
descriptor that uses the mapping.

Reference to v1:
	https://lkml.org/lkml/2012/12/6/71

Changes since v1:
- synced patch series with next-20131016
- removed no longer needed "async_memset: convert to dmaengine_unmap_data"
  patch (patch #5 in v1)
- added patch #1 ("dmatest: make driver unmap also source buffers by itself")
- added patch #11 ("NTB: convert to dmaengine_unmap_data")
- prepared pl330 driver for adding missing unmap in patch #3
- in patch #4:
  - fixed IS_ENABLED() check
  - fixed release ordering in dmaengine_destroy_unmap_pool()
  - fixed check for success in dmaengine_init_unmap_pool()
  - replaced kmem_cache_free() by mempool_free()
  - added missing unmap->len initializations
  - added __init tag to dmaengine_init_unmap_pool()
- in patch #5:
  - added missing unmap->len initialization
  - fixed whitespace damage
- did minor cleanups in patches #6 & #7
- added temporary dma_dest array in patches #8 & #9

Tested on Exynos4412-based Trats2 board containing PL330 DMA engine, with
additional patches doing memory copying tests using DMA memcpy API.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics


Bartlomiej Zolnierkiewicz (4):
  dmatest: make driver unmap also source buffers by itself
  NTB: convert to dmaengine_unmap_data
  dmaengine: remove DMA unmap from drivers
  dmaengine: remove DMA unmap flags

Dan Williams (9):
  dmaengine: consolidate memcpy apis
  dmaengine: prepare for generic 'unmap' data
  dmaengine: reference counted unmap data
  async_memcpy: convert to dmaengine_unmap_data
  async_xor: convert to dmaengine_unmap_data
  async_xor_val: convert to dmaengine_unmap_data
  async_raid6_recov: convert to dmaengine_unmap_data
  async_pq: convert to dmaengine_unmap_data
  async_pq_val: convert to dmaengine_unmap_data

 arch/arm/include/asm/hardware/iop3xx-adma.h |  30 ----
 arch/arm/include/asm/hardware/iop_adma.h    |   4 -
 arch/arm/mach-iop13xx/include/mach/adma.h   |  26 ---
 crypto/async_tx/async_memcpy.c              |  37 ++--
 crypto/async_tx/async_pq.c                  | 174 ++++++++++--------
 crypto/async_tx/async_raid6_recov.c         |  61 +++++--
 crypto/async_tx/async_xor.c                 | 123 +++++++------
 drivers/ata/pata_arasan_cf.c                |   3 +-
 drivers/dma/amba-pl08x.c                    |  32 +---
 drivers/dma/at_hdmac.c                      |  26 +--
 drivers/dma/dmaengine.c                     | 262 ++++++++++++++++++---------
 drivers/dma/dmatest.c                       |   9 +-
 drivers/dma/dw/core.c                       |  21 +--
 drivers/dma/ep93xx_dma.c                    |  30 +---
 drivers/dma/fsldma.c                        |  17 +-
 drivers/dma/ioat/dma.c                      |  20 +--
 drivers/dma/ioat/dma.h                      |  12 --
 drivers/dma/ioat/dma_v2.c                   |   2 +-
 drivers/dma/ioat/dma_v3.c                   | 179 +-----------------
 drivers/dma/iop-adma.c                      |  97 +---------
 drivers/dma/mv_xor.c                        |  45 +----
 drivers/dma/pl330.c                         |   2 +
 drivers/dma/ppc4xx/adma.c                   | 270 +---------------------------
 drivers/dma/timb_dma.c                      |  37 +---
 drivers/dma/txx9dmac.c                      |  25 +--
 drivers/media/platform/m2m-deinterlace.c    |   3 +-
 drivers/media/platform/timblogiw.c          |   2 +-
 drivers/misc/carma/carma-fpga.c             |   3 +-
 drivers/mtd/nand/atmel_nand.c               |   3 +-
 drivers/mtd/nand/fsmc_nand.c                |   2 -
 drivers/net/ethernet/micrel/ks8842.c        |   6 +-
 drivers/ntb/ntb_transport.c                 |  64 +++++--
 drivers/spi/spi-dw-mid.c                    |   4 +-
 include/linux/dmaengine.h                   |  64 +++++--
 34 files changed, 538 insertions(+), 1157 deletions(-)

-- 
1.8.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/