linux-kernel - Re: [PATCH] vsprintf: add Bluetooth UUID %pU[rR] format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1382217893.2041.27.camel@joe-AO722>
Date:	Sat, 19 Oct 2013 14:24:53 -0700
From:	Joe Perches <joe@...ches.com>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vsprintf: add Bluetooth UUID %pU[rR] format specifier

On Sat, 2013-10-19 at 09:25 -0700, Marcel Holtmann wrote:
> The Bluetooth UUID is used in big endian reversed order. Add new
> modifier to print a UUID in big endian, but where the input byte
> stream is actually in reversed order.
> This is similar to %pMR that allows to print a MAC address in
> reversed order since that is how the Bluetooth BD_ADDR is
> actually represented in a byte stream.

Seems sensible.  Other than print_bt_uuid, is
there another place where will it be used?

Are you going to convert print_bt_uuid to use this?

> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
[]
> @@ -1106,6 +1106,7 @@ char *uuid_string(char *buf, char *end, const u8 *addr,
>  	static const u8 le[16] = {3,2,1,0,5,4,7,6,8,9,10,11,12,13,14,15};
>  	const u8 *index = be;
>  	bool uc = false;
> +	bool reversed = false;
>  
>  	switch (*(++fmt)) {

Could there ever be a little endian reversed UUID?

Might it be useful to change this to:

	while (isalpha(*++fmt)) {
		switch (*fmt) {

etc?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/