| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Oct 2013 18:49:19 -0400 (EDT) From: David Miller <davem@...emloft.net> To: geyslan@...il.com Cc: kernel-br@...glegroups.com, herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] crypto: n2_core: insert '!err' condition in else scope From: Geyslan Gregório Bem <geyslan@...il.com> Date: Sat, 19 Oct 2013 19:42:35 -0300 > 2013/10/19 David Miller <davem@...emloft.net>: >> From: "Geyslan G. Bem" <geyslan@...il.com> >> Date: Sat, 19 Oct 2013 10:09:31 -0300 >> >>> This patch moves the '!err' condition into the above else scope, >>> what is more obvious and has the secondary goal of avoid false-positives >>> in statical analyze tools. >>> >>> Signed-off-by: Geyslan G. Bem <geyslan@...il.com> >> >> I do not think patches should be applied to satisfy tools if the >> code is semantically correct. > > Yes, Miller, I agree. But as I mentioned: > ".. and has as the 'secondary' goal of avoid false-positives in > statical analyze tools." > > The 'primary' goal is to not repeat a condition test: > "This patch moves the '!err' condition into the above else scope, what > is more obvious ..." I still do not feel that this change is a net-positive. Sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists