linux-kernel - Re: [PATCH v3 8/9] ACPI, APEI, CPER: Cleanup CPER memory error output format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131019112658.GB16597@gchen.bj.intel.com>
Date:	Sat, 19 Oct 2013 07:26:58 -0400
From:	Chen Gong <gong.chen@...ux.intel.com>
To:	"Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
Cc:	tony.luck@...el.com, bp@...en8.de, joe@...ches.com,
	m.chehab@...sung.com, arozansk@...hat.com,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 8/9] ACPI, APEI, CPER: Cleanup CPER memory error
 output format

On Fri, Oct 18, 2013 at 05:31:21PM +0530, Naveen N. Rao wrote:
> Date: Fri, 18 Oct 2013 17:31:21 +0530
> From: "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
> To: "Chen, Gong" <gong.chen@...ux.intel.com>, tony.luck@...el.com,
>  bp@...en8.de, joe@...ches.com, m.chehab@...sung.com
> CC: arozansk@...hat.com, linux-acpi@...r.kernel.org,
>  linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v3 8/9] ACPI, APEI, CPER: Cleanup CPER memory error
>  output format
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101
>  Thunderbird/24.0
> 
[...]
> >
> >@@ -358,17 +349,21 @@ void cper_estatus_print(const char *pfx,
> >  	struct acpi_generic_data *gdata;
> >  	unsigned int data_len, gedata_len;
> >  	int sec_no = 0;
> >+	char newpfx[64];
> >  	__u16 severity;
> >
> >-	printk("%s""Generic Hardware Error Status\n", pfx);
> >  	severity = estatus->error_severity;
> >-	printk("%s""severity: %d, %s\n", pfx, severity,
> >-	       cper_severity_str(severity));
> >+	if (severity != CPER_SEV_FATAL)
> 
> Shouldn't this just be (severity == CPER_SEV_CORRECTED)?
> 
> Thanks,
> Naveen
> 
IMO, only fatal error can't be handlered gracefully in current
kernel plus H/W. Once it can be recovered by H/W and OS, we
can call it recovered.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)