linux-kernel - Re: [PATCH] crypto: n2_core: insert '!err' condition in else scope

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131020121231.GA20425@gondor.apana.org.au>
Date:	Sun, 20 Oct 2013 20:12:31 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Geyslan Gregório Bem <geyslan@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	kernel-br <kernel-br@...glegroups.com>,
	"open list:CRYPTO API" <linux-crypto@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: n2_core: insert '!err' condition in else scope

On Sat, Oct 19, 2013 at 08:13:25PM -0300, Geyslan Gregório Bem wrote:
> 
> I can understand you. You don't want to break your git history
> (blame). But when a code is clearly more readable/understandable you
> must assume that it has a huge net-positive.
> 
> The patch improves the code in three ways:
> - Only one if/else;
> - Not blame on static analysis tools.
> - And avoid more discussion about that in the future (nobody will send
> patches like this to disturb you about that part of code).
> 
> The decision is yours.

FWIW I totally agree with David so your patch isn't going in.
Sorry.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/