linux-kernel - Re: [PATCH 09/19] perf tools: Fix 32-bit cross build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5264ED95.2020101@intel.com>
Date:	Mon, 21 Oct 2013 12:02:13 +0300
From:	Adrian Hunter <adrian.hunter@...el.com>
To:	Jiri Olsa <jolsa@...hat.com>
CC:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 09/19] perf tools: Fix 32-bit cross build

On 21/10/13 11:46, Jiri Olsa wrote:
> On Mon, Oct 21, 2013 at 08:53:04AM +0300, Adrian Hunter wrote:
>> On 20/10/13 23:42, Jiri Olsa wrote:
>>> On Fri, Oct 18, 2013 at 03:29:06PM +0300, Adrian Hunter wrote:
>>>> Setting EXTRA_CFLAGS=-m32 did not work because CFLAGS
>>>> was not passed around.
>>>
>>> this breaks feature detection for me on x86_64,
>>> I've got following errors misdetection with this patch:
>>>
>>> ...                       libperl: [ OFF ]
> 
> how about this one?

I will check it out.

> 
>>> ...                       on-exit: [ OFF ]
>>>
>>> and the build fails as well:
>>>
>>>   CC       builtin-stat.o
>>> builtin-record.c:42:12: error: static declaration of ‘on_exit’ follows non-static declaration
>>> In file included from util/util.h:51:0,
>>>                  from builtin.h:4,
>>>                  from builtin-record.c:8:
>>> /usr/include/stdlib.h:536:12: note: previous declaration of ‘on_exit’ was here
>>> make[1]: *** [builtin-record.o] Error 1
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: *** [all] Error 2
>>
>> That is fixed in patch 11: perf tools: Fix test_on_exit for 32-bit build
> 
> hum, could we apply those patches in reverse order?
> I think the notion is not to break build deliberatelly
> for the bisection sake.

Oh, I had thought it was a 32-bit only problem.
Yes, I will re-order the patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/