linux-kernel - Re: [PATCH 13/19] perf tools: Fix libunwind build and feature detection for 32-bit build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131021141428.GB2245@ghostprotocols.net>
Date:	Mon, 21 Oct 2013 11:14:28 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 13/19] perf tools: Fix libunwind build and feature
 detection for 32-bit build

Em Sun, Oct 20, 2013 at 10:43:46PM +0200, Jiri Olsa escreveu:
> On Fri, Oct 18, 2013 at 03:29:10PM +0300, Adrian Hunter wrote:
> > Use -lunwind-x86 instead of -lunwind-x86_64 for 32-bit build.

> > Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>

> Acked-by: Jiri Olsa <jolsa@...hat.com>

Doesn't apply because it depends on a patch in this series that I made a
question about, the "CFLAGS=-g ... one, but then can we avoid touching
this feature_check_code line with feature specific stuff, i.e. can't we
just touch LDFLAGS or CFLAGS?

- Arnaldo

--- tools/perf/config/Makefile
+++ tools/perf/config/Makefile
@@ -94,7 +96,7 @@
 
 feature_check = $(eval $(feature_check_code))
 define feature_check_code
-  feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(CFLAGS)" LDFLAGS=$(LDFLAGS) -C config/feature-checks test-$1 >/dev/null 2>/dev/null && echo 1 || echo 0)
+  feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(CFLAGS)" LDFLAGS=$(LDFLAGS) LIBUNWIND_LIBS="$(LIBUNWIND_LIBS)" -C config/feature-checks test-$1 >/dev/null 2>/dev/null && echo 1 || echo 0)
 endef
 
 feature_set = $(eval $(feature_set_code))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/