linux-kernel - Re: [PATCH] watchdog: Get rid of MODULE_ALIAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131021190625.GA19242@roeck-us.net>
Date:	Mon, 21 Oct 2013 12:06:25 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	linux-watchdog@...r.kernel.org, Wim Van Sebroeck <wim@...ana.be>,
	Stephen Warren <swarren@...dotorg.org>,
	Mike Frysinger <vapier.adi@...il.com>,
	Wan ZongShun <mcuos.com@...il.com>,
	Ben Dooks <ben-linux@...ff.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Jim Cromie <jim.cromie@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] watchdog: Get rid of MODULE_ALIAS_MISCDEV statements

On Mon, Oct 21, 2013 at 05:38:49PM +0200, Jean Delvare wrote:
> I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
> and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.
> 
> Either the device is enumerated and the driver already has a module
> alias (e.g. PCI, USB etc.) that will get the right driver loaded
> automatically.
> 
> Or the device is not enumerated and loading its driver will lead to
> more or less intrusive hardware poking. Such hardware poking should be
> limited to a bare minimum, so the user should really decide which
> drivers should be tried and in what order. Trying them all in
> arbitrary order can't do any good.
> 
> On top of that, loading that many drivers at once bloats the kernel
> log. Also many drivers will stay loaded afterward, bloating the output
> of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
> loaded as a dependency) can't even be unloaded!
> 
> If defining char-major-10-130 is needed then it should happen in
> user-space.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Wim Van Sebroeck <wim@...ana.be>
> Cc: Stephen Warren <swarren@...dotorg.org>
> Cc: Mike Frysinger <vapier.adi@...il.com>
> Cc: Wan ZongShun <mcuos.com@...il.com>
> Cc: Ben Dooks <ben-linux@...ff.org>
> Cc: Kukjin Kim <kgene.kim@...sung.com>
> Cc: Zwane Mwaikambo <zwane@....linux.org.uk>
> Cc: Jim Cromie <jim.cromie@...il.com>
> Cc: Guenter Roeck <linux@...ck-us.net>

Makes sense to me.

Acked-by: Guenter Roeck <linux@...ck-us.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/