linux-kernel - Re: [RFC trivial] printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1382457444.2041.82.camel@joe-AO722>
Date:	Tue, 22 Oct 2013 08:57:24 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dirk Gouders <dirk@...ders.net>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC trivial] printk.c: /proc/vmcore instead of
 /proc/vmcoreinfo in comments?

On Tue, 2013-10-22 at 14:15 +0200, Dirk Gouders wrote:
> Hello Joe,
> 
> when having a look at printk.c, I noticed that two comments refer
> to /proc/vmcoreinfo and I wonder if that should not read /proc/vmcore.
> 
> While at it, a typo in one of those coments could also be fixed.

Hi Dirk.

Thanks and yes this is sensible.
Adding Andrew Morton to cc's and resending as plain-text

>From 2ef84ff3187633a3156c3a967c1dfc294292e492 Mon Sep 17 00:00:00 2001
From: Dirk Gouders <dirk@...ders.net>
Date: Tue, 22 Oct 2013 13:51:15 +0200
Subject: [PATCH] printk.c: comments should refer to /proc/vmcore instead of
 /proc/vmcoreinfo

In one of those comments a typo was fixed, too.

Signed-off-by: Dirk Gouders <dirk@...ders.net>
---
 kernel/printk/printk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index b4e8500..694d1f9 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -705,9 +705,9 @@ const struct file_operations kmsg_fops = {
 
 #ifdef CONFIG_KEXEC
 /*
- * This appends the listed symbols to /proc/vmcoreinfo
+ * This appends the listed symbols to /proc/vmcore
  *
- * /proc/vmcoreinfo is used by various utiilties, like crash and makedumpfile to
+ * /proc/vmcore is used by various utilities, like crash and makedumpfile to
  * obtain access to symbols that are otherwise very difficult to locate.  These
  * symbols are specifically used so that utilities can access and extract the
  * dmesg log from a vmcore file after a crash.
-- 
1.8.3.2



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/