lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Oct 2013 09:36:34 -0700 From: Joe Perches <joe@...ches.com> To: Andi Kleen <andi@...stfloor.org> Cc: mmarek@...e.cz, linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com> Subject: Re: [PATCH 2/3] Kbuild: Handle longer symbols in kallsyms.c On Tue, 2013-10-22 at 08:46 -0700, Andi Kleen wrote: > From: Andi Kleen <ak@...ux.intel.com> > > Also warn for too long symbols [] > diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c [] > @@ -27,7 +27,7 @@ > #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0])) > #endif > > -#define KSYM_NAME_LEN 128 > +#define KSYM_NAME_LEN 256 Maybe nicer to get these #defines via #include <> to avoid getting out of sync. > struct sym_entry { > unsigned long long addr; > @@ -118,6 +118,12 @@ static int read_symbol(FILE *in, struct sym_entry *s) > fprintf(stderr, "Read error or end of file.\n"); > return -1; > } > + if (strlen(str) > KSYM_NAME_LEN) { > + fprintf(stderr, "Symbol %s too long for kallsyms.\n" > + "Please increase KSYM_NAME_LEN both in kernel and kallsyms.c", > + str); Missing newline? Also maybe nicer to show symbol length and KSYM_NAME_LEN values. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists